Changeset 1947

Show
Ignore:
Timestamp:
01/27/07 01:44:00 (2 years ago)
Author:
mbr
Message:

strlen() fixes (need +1 for ending NULL)

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • psad/trunk/psadwatchd.c

    r1945 r1947  
    335335    int arg_num=0, non_ws, i; 
    336336 
    337     prog_argv[arg_num] = (char *) malloc(strlen(binary)); 
     337    prog_argv[arg_num] = (char *) malloc(strlen(binary)+1); 
    338338    if (prog_argv[arg_num] == NULL) { 
    339339        exit(EXIT_FAILURE); 
    340340    } 
    341     strlcpy(prog_argv[arg_num], binary, strlen(binary)); 
     341    strlcpy(prog_argv[arg_num], binary, strlen(binary)+1); 
    342342    arg_num++; 
    343343 
    …… 
    384384        } 
    385385    } 
     386 
    386387    if (arg_num >= MAX_ARG_LEN) 
    387388        exit(EXIT_FAILURE); 
    388  
     389    prog_argv[arg_num] = (char *) malloc(1); 
     390    if (prog_argv[arg_num] == NULL) { 
     391        exit(EXIT_FAILURE); 
     392    } 
    389393    prog_argv[arg_num] = NULL; 
    390394 
    …… 
    394398    else if (child_pid > 0) { 
    395399        wait(NULL); 
    396         for (i=0; i < arg_num; i++) { 
     400        for (i=0; i<=arg_num; i++) { 
    397401            free(prog_argv[i]); 
    398402        }